Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all data type combinations are being tested with the integral function performance tests #15439

Closed
everton1984 opened this issue Sep 2, 2019 · 3 comments

Comments

@everton1984
Copy link
Contributor

commented Sep 2, 2019

System information (version)
  • OpenCV => 3.4
  • Operating System / Platform => Linux 64bit
  • Compiler => gcc
Detailed description

I'm trying to analyse the performance of the integral function for several parameter
combinations since some of those combinations use HAL instructions and others do
not. Running the performance tests I realised that only one combinations of matrix
size for square sum and sum matrices.

@alalek

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

There is no goal to test everything on performance regressions.
Only most interested/useful/representative cases should be tested for performance on regular basis.

If you want more detailed tests, please create them with DISABLED_ prefix (which you can use during development / optimization of the target function via --gtest_also_run_disabled_tests).

@everton1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Where should I add the DISABLED_ prefix exactly? Before PERF_TEST_P?

@everton1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Just made the new tests disabled by default on PR #15440 as requested.

@alalek alalek added this to the 3.4.8 milestone Sep 5, 2019

@alalek alalek added category: imgproc and removed RFC labels Sep 5, 2019

@alalek alalek closed this Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.