New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added HoughCircles in ocl module #267

Merged
merged 14 commits into from Jan 19, 2013

Conversation

5 participants
@pclove1
Contributor

pclove1 commented Dec 26, 2012

Demo video clip and formal documentation are available at:
http://seunghoon-cis565.blogspot.com/2012/12/final-project-circular-hough-transform.html

Show outdated Hide outdated modules/ocl/perf/perf_hough.cpp
// Copyright (C) 2010-2012, Advanced Micro Devices, Inc., all rights reserved.
// Third party copyrights are property of their respective owners.
//
// @Authors

This comment has been minimized.

@kirill-korniakov

kirill-korniakov Dec 28, 2012

Contributor

In OpenCV we do not put our emails to the code. Actually you shouldn't modify standard header at all. All information about your commitment will remain in git commits' info. So, I would ask you to remove information about your names from all file headers.

@kirill-korniakov

kirill-korniakov Dec 28, 2012

Contributor

In OpenCV we do not put our emails to the code. Actually you shouldn't modify standard header at all. All information about your commitment will remain in git commits' info. So, I would ask you to remove information about your names from all file headers.

This comment has been minimized.

@pclove1

pclove1 Dec 28, 2012

Contributor

Thanks for your comment.
I removed personal info from all file headers.

@pclove1

pclove1 Dec 28, 2012

Contributor

Thanks for your comment.
I removed personal info from all file headers.

Show outdated Hide outdated modules/ocl/perf/perf_hough.cpp
}
INSTANTIATE_TEST_CASE_P(Hough, HoughCircles_Perf,

This comment has been minimized.

@kirill-korniakov

kirill-korniakov Dec 28, 2012

Contributor

This perf test is not properly designed and implemented. You shouldn't use cvGetTickCount at all, you should use constructs like TEST_CYCLE(), and you must use PERF_TEST_P instead of INSTANTIATE_TEST_CASE_P. The reason is that your test can't be analyzed with OpenCV scripts.

To find more about all of this, you should read http://opencv.willowgarage.com/wiki/ValueParameterizedPerfTests (this page describes how you should design your perf test) and http://opencv.willowgarage.com/wiki/AnalyzePerfTestsLogs (this page describes how you should analyze performance).

For examples you can study these files:

@kirill-korniakov

kirill-korniakov Dec 28, 2012

Contributor

This perf test is not properly designed and implemented. You shouldn't use cvGetTickCount at all, you should use constructs like TEST_CYCLE(), and you must use PERF_TEST_P instead of INSTANTIATE_TEST_CASE_P. The reason is that your test can't be analyzed with OpenCV scripts.

To find more about all of this, you should read http://opencv.willowgarage.com/wiki/ValueParameterizedPerfTests (this page describes how you should design your perf test) and http://opencv.willowgarage.com/wiki/AnalyzePerfTestsLogs (this page describes how you should analyze performance).

For examples you can study these files:

This comment has been minimized.

@pclove1

pclove1 Dec 28, 2012

Contributor

Thanks for your kind advice and references.
I modified performance test regarding to your request.

FYI, every other performance tests in the current ocl module don't use PERF_TEST_P and TEST_CYCLE() at all.

@pclove1

pclove1 Dec 28, 2012

Contributor

Thanks for your kind advice and references.
I modified performance test regarding to your request.

FYI, every other performance tests in the current ocl module don't use PERF_TEST_P and TEST_CYCLE() at all.

@ghost ghost assigned vpisarev Dec 28, 2012

@asmorkalov

This comment has been minimized.

Show comment
Hide comment
@asmorkalov

asmorkalov Dec 28, 2012

Contributor

Vadim, could you contact with OpenCL module developers to review this commit.

Contributor

asmorkalov commented Dec 28, 2012

Vadim, could you contact with OpenCL module developers to review this commit.

@pclove1

This comment has been minimized.

Show comment
Hide comment
@pclove1

pclove1 Dec 28, 2012

Owner

Another question, I see the following warning from gcc when compiling this performance test:

modules/ocl/perf/perf_hough.cpp: In function ‘testing::internal::ParamGenerator<std::tr1::tuple<cv::Size_<int>, float, float> > gtest_Size_Dp_MinDist_OCL_HoughCircles_EvalGenerator_()’:
modules/ocl/perf/perf_hough.cpp:60:1: warning: no previous declaration for ‘testing::internal::ParamGenerator<std::tr1::tuple<cv::Size_<int>, float, float> > gtest_Size_Dp_MinDist_OCL_HoughCircles_EvalGenerator_()’ [-Wmissing-declarations]

Did I something wrong?
Please share your thought about this.
Thanks.

Another question, I see the following warning from gcc when compiling this performance test:

modules/ocl/perf/perf_hough.cpp: In function ‘testing::internal::ParamGenerator<std::tr1::tuple<cv::Size_<int>, float, float> > gtest_Size_Dp_MinDist_OCL_HoughCircles_EvalGenerator_()’:
modules/ocl/perf/perf_hough.cpp:60:1: warning: no previous declaration for ‘testing::internal::ParamGenerator<std::tr1::tuple<cv::Size_<int>, float, float> > gtest_Size_Dp_MinDist_OCL_HoughCircles_EvalGenerator_()’ [-Wmissing-declarations]

Did I something wrong?
Please share your thought about this.
Thanks.

@pclove1

This comment has been minimized.

Show comment
Hide comment
@pclove1

pclove1 Jan 17, 2013

Contributor

When can I receive your feedback about this pull request?
Thanks.

Contributor

pclove1 commented Jan 17, 2013

When can I receive your feedback about this pull request?
Thanks.

@vpisarev

This comment has been minimized.

Show comment
Hide comment
@vpisarev

vpisarev Jan 18, 2013

Contributor

👍

Contributor

vpisarev commented Jan 18, 2013

👍

taka-no-me pushed a commit that referenced this pull request Jan 19, 2013

@opencv-pushbot opencv-pushbot merged commit 06da75f into opencv:master Jan 19, 2013

1 check was pending

default precommit_android was executed, precommit_docs was executed, precommit_windows was executed, precommit_macos was executed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment