Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Soft cascade refactoring and fixes #311

Merged
merged 12 commits into from Jan 21, 2013

Conversation

4 participants
Contributor

cuda-geek commented Jan 18, 2013

This request contains only improvements for already pushed soft cascade functionality.

@ghost ghost assigned vpisarev Jan 18, 2013

Contributor

mdim commented Jan 21, 2013

@cuda-geek Marina, did you see that your PR has warnings on almost all platforms? As a person on duty for this week I have to remind that only "green" PR will be merged ;)

Contributor

cuda-geek commented Jan 21, 2013

@mdim: sorry, but this warning status is about failed tests. I've request pull to opencv_extra that fix failed tests.

Contributor

mdim commented Jan 21, 2013

@cuda-geek ok, I see. It's interesting how we provide the synchronization of related pull requests to opencv and opencv_extra now..

Contributor

cuda-geek commented Jan 21, 2013

@mdim: This is an open question now. I think we should merge pull request to the opencv_extra first to verify that this pull request become green.

Contributor

mdim commented Jan 21, 2013

@cuda-geek ok, just worry that your PR will dangling in yellow state.
@etalanin Evgeny, Kirill told me that you've already added some synchronization. Can you please investigate why we have the problem with this PR? (just because it was created before you added the sync?)
@vpisarev Vadim, can you please review this PR (it has to be "green" actually, see above).

Contributor

vpisarev commented Jan 21, 2013

ok, the new test data pushed to itseez/opencv_extra; let's run tests with it

Contributor

cuda-geek commented Jan 21, 2013

@vpisarev, builders became green.

Contributor

vpisarev commented Jan 21, 2013

👍

@opencv-pushbot opencv-pushbot merged commit e15bdea into opencv:master Jan 21, 2013

1 check was pending

default precommit_android was executed, precommit_docs was executed, precommit_windows was executed, precommit_macos was executed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment