Fix tautologies in calibfilter.cpp which cause a build failure when using -Werror=address with clang-3.5 #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing -Werror=address with clang-3.5 http://code.opencv.org/issues/4048 Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
👍 |
vpisarev
added a commit
that referenced
this pull request
Dec 6, 2014
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 16, 2014
Obtained from: opencv/opencv#3488 PR: ports/195727 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@374818 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 16, 2014
Obtained from: opencv/opencv#3488 PR: ports/195727
|
Finally I could solve my problem, thanks a lotttttt |
svmhdvn
pushed a commit
to svmhdvn/freebsd-ports
that referenced
this pull request
Jan 10, 2024
Obtained from: opencv/opencv#3488 PR: ports/195727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://code.opencv.org/issues/4048
calibfilter.cpp:98:9: error: comparison of array 'this->latestPoints' not equal to a null pointer is always true [-Werror,-Wtautological-pointer-compare]
if (latestPoints != __null)
^~~~~~~~~~ ~~~~
calibfilter.cpp:526:9: error: address of array 'this->latestCounts' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
if( latestCounts )
~ ^~~~~~~~~~~
2 errors generated.
Signed-off-by: Jeremy Huddleston Sequoia jeremyhu@apple.com