Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PR #7159 (OSX AVFoundation support) #7266

Merged
merged 4 commits into from Sep 16, 2016

Conversation

alalek
Copy link
Member

@alalek alalek commented Sep 9, 2016

Related #7159

yoffy and others added 4 commits August 23, 2016 10:51
Support setting CAP_PROP_MODE to capture grayscale or YUV frames much
faster from CV_CAP_AVFOUNDATION_MAC.
CvVideoWriter_AVFoundation_Mac had a serious buffer release bug.

Also made writeFrame() block until isReadyForMoreMediaData rather than
return an error.
@varunkworld
Copy link

varunkworld commented Sep 15, 2016

@alalek I am new here. Can you tell me what am I supposed to do now about the "QTKit problem" #7292 ?

@alalek
Copy link
Member Author

alalek commented Sep 15, 2016

@varunkworld After these steps:

$ git clone https://github.com/Itseez/opencv.git
$ cd opencv

Apply this patch:

$ git fetch https://github.com/opencv/opencv.git +pull/7266/head:pr7266
$ git checkout pr7266 # instread of 3.0.0 or 3.1.0

And continue with "Step 8"

BTW, "opencv_contrib" repo should be synchronized with "opencv" repo, so checkout "master" branch also.

@varunkworld
Copy link

varunkworld commented Sep 16, 2016

@alalek Thanks !

@vpisarev vpisarev self-assigned this Sep 16, 2016
@vpisarev
Copy link
Contributor

👍

@opencv-pushbot opencv-pushbot merged commit f85e33f into opencv:master Sep 16, 2016
opencv-pushbot pushed a commit that referenced this pull request Sep 16, 2016
@pr0methaz1ne
Copy link

@alalek Wait so what do you type to install the contrib?

@toaditoad
Copy link

toaditoad commented Sep 19, 2016

@pr0methaz1ne I think you just have to add --with-contrib (assuming you try to install it with homebrew).
If not, you might check out step 7 at http://www.pyimagesearch.com/2015/06/15/install-opencv-3-0-and-python-2-7-on-osx/ for further information about (I didn't test it, though!):

$ git clone https://github.com/Itseez/opencv_contrib
$ cd opencv_contrib
$ git checkout master

Thanks guys, finally my installation worked with (see also #7159):
brew install opencv3 --with-java --with-contrib --with-python --HEAD

@cecabert
Copy link

cecabert commented Oct 1, 2016

Thanks for the fix but apparently there is an issue with the getProperty(int) method. At the moment only base class method is called therefore always returning 0.
Shouldn't virtual double CvCaptureCAM::getProperty(int property_id) const; and virtual double CvCaptureFile::getProperty(int property_id) const; be declared as non-const to respect CvCapture interface ?

@alalek
Copy link
Member Author

alalek commented Oct 2, 2016

@ChristopheEcabert Nice catch! Thanks! Could you check #7383?

@aaronbatchelder
Copy link

@alalek thanks for being on top of this! The below suggestions worked great on Sierra with Xcode 8.

$ git clone https://github.com/Itseez/opencv.git
$ cd opencv

Apply this patch:

$ git fetch https://github.com/opencv/opencv.git +pull/7266/head:pr7266
$ git checkout pr7266 # instread of 3.0.0 or 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port/backport done Label for maintainers. Authors of PR can ignore this
Development

Successfully merging this pull request may close these issues.

None yet

10 participants