Updated PR #7159 (OSX AVFoundation support) #7266

Merged
merged 4 commits into from Sep 16, 2016

Projects

None yet

10 participants

@alalek
Contributor
alalek commented Sep 9, 2016

Related #7159

yoffy and others added some commits May 8, 2016
@yoffy @rgov yoffy add VideoCapture / VideoWriter AVFoundation implementation for Mac 767780a
@mself @rgov mself Add support for CAP_PROP_MODE
Support setting CAP_PROP_MODE to capture grayscale or YUV frames much
faster from CV_CAP_AVFOUNDATION_MAC.
a92da54
@mself @rgov mself Fix buffer release issue
CvVideoWriter_AVFoundation_Mac had a serious buffer release bug.

Also made writeFrame() block until isReadyForMoreMediaData rather than
return an error.
0882936
@alalek alalek videoio: refactor AVFoundation code integration f85e33f
@varunkworld
varunkworld commented Sep 15, 2016 edited

@alalek I am new here. Can you tell me what am I supposed to do now about the "QTKit problem" #7292 ?

@alalek
Contributor
alalek commented Sep 15, 2016

@varunkworld After these steps:

$ git clone https://github.com/Itseez/opencv.git
$ cd opencv

Apply this patch:

$ git fetch https://github.com/opencv/opencv.git +pull/7266/head:pr7266
$ git checkout pr7266 # instread of 3.0.0 or 3.1.0

And continue with "Step 8"

BTW, "opencv_contrib" repo should be synchronized with "opencv" repo, so checkout "master" branch also.

@varunkworld
varunkworld commented Sep 16, 2016 edited

@alalek Thanks !

@vpisarev vpisarev self-assigned this Sep 16, 2016
@vpisarev
Contributor

👍

@opencv-pushbot opencv-pushbot merged commit f85e33f into opencv:master Sep 16, 2016

1 check passed

default Required builds passed
Details
@pr0methaz1ne

@alalek Wait so what do you type to install the contrib?

@toaditoad
toaditoad commented Sep 19, 2016 edited

@pr0methaz1ne I think you just have to add --with-contrib (assuming you try to install it with homebrew).
If not, you might check out step 7 at http://www.pyimagesearch.com/2015/06/15/install-opencv-3-0-and-python-2-7-on-osx/ for further information about (I didn't test it, though!):

$ git clone https://github.com/Itseez/opencv_contrib
$ cd opencv_contrib
$ git checkout master

Thanks guys, finally my installation worked with (see also #7159):
brew install opencv3 --with-java --with-contrib --with-python --HEAD

@ChristopheEcabert

Thanks for the fix but apparently there is an issue with the getProperty(int) method. At the moment only base class method is called therefore always returning 0.
Shouldn't virtual double CvCaptureCAM::getProperty(int property_id) const; and virtual double CvCaptureFile::getProperty(int property_id) const; be declared as non-const to respect CvCapture interface ?

@alalek
Contributor
alalek commented Oct 2, 2016

@ChristopheEcabert Nice catch! Thanks! Could you check #7383?

@aaronbatchelder

@alalek thanks for being on top of this! The below suggestions worked great on Sierra with Xcode 8.

$ git clone https://github.com/Itseez/opencv.git
$ cd opencv

Apply this patch:

$ git fetch https://github.com/opencv/opencv.git +pull/7266/head:pr7266
$ git checkout pr7266 # instread of 3.0.0 or 3.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment