Skip to content

Conversation

@edgarriba
Copy link
Contributor

The first of a set of functions in order import scenes from different structure from motion frameworks such Bundler, VisualSfM, OpenSfM, OpenMVG and TheiSfM.

The current PR has a Bundler import function, a sample code with its correspondent tutorial

@alalek
Copy link
Member

alalek commented Jan 14, 2016

Looks good!
Could your please squash commits into one to eliminate unnecessary intermediate changes (picture added in both commits)

@alalek
Copy link
Member

alalek commented Jan 19, 2016

Something is going wrong during commits squash. Another commit with "CompilerFix" has been added and merged here: #484 (a5e7d8f)

$ git fetch upstream
$ git rebase -i upstream/master
# Edit to this and save:
# pick 0726948 add io submodule for import scenes
# f 698bfb7 fix rotation issue + small docs errors
$ git push -f origin sfm

Or use something like this #290 (comment)

@alalek
Copy link
Member

alalek commented Jan 19, 2016

Thank you!
👍

@alalek
Copy link
Member

alalek commented Jan 19, 2016

@edgarriba Please remove your opencv_extra:sfm branch

@edgarriba
Copy link
Contributor Author

done

@opencv-pushbot opencv-pushbot merged commit d3dd859 into opencv:master Jan 19, 2016
opencv-pushbot pushed a commit that referenced this pull request Jan 19, 2016
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants