Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSLIC (Manifold SLIC) #923

Merged
merged 1 commit into from Jan 11, 2017

Conversation

@cbalint13
Copy link
Contributor

commented Dec 28, 2016

This PR adds MSLIC [1] superpixels for image segmentation.

Some infos:

  • Implementation here is properly cited in respect with author.
  • Implementation is derived using BSD, author [2] agreed for the license terms used here.
  • Implementation booth follows opencv's coding standard but author original code.
  • Implementation behave as original one but speed is improved using opencv parallelism.
  • Implementation can handle CV_{XX}C{Y} image types ( {Y} = multispectral ).
  • Implementation have documented flexible parameters and follows original demonstrator.

[1] CVPR2016 - MSLIC
[2] Yong-Jin Liu <liuyongjin [at] tsinghua [dot] edu [dot] cn>

Author is invited to this PR review, he may interact within process.

slic-demo

@cbalint13 cbalint13 force-pushed the cbalint13:mslic branch 4 times, most recently from ed8dba9 to bbcf2e4 Dec 28, 2016

@cbalint13 cbalint13 force-pushed the cbalint13:mslic branch from bbcf2e4 to 3392514 Jan 7, 2017

@@ -138,21 +140,22 @@ class CV_EXPORTS_W SuperpixelSLIC : public Algorithm

This comment has been minimized.

Copy link
@sovrasov

sovrasov Jan 10, 2017

Contributor

Brief description of this function should be changed to something like Initializes a SuperpixelSLIC object. It's an old copy-paste error.

![image](pics/superpixels_slic.png)
*/

enum SLIC { SLIC = 100, SLICO = 101 };
enum SLIC { SLIC = 100, SLICO = 101, MSLIC = 102 };

This comment has been minimized.

Copy link
@sovrasov

sovrasov Jan 10, 2017

Contributor

Please, move this enum to the line 63 in this file to let Doxygen process it correctly.
Now description of the createSuperpixelSLIC function is empty.

@sovrasov

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2017

To enable switching to MSLIC in sample via trackbar 1 should be replaced with 2 here.

@cbalint13 cbalint13 force-pushed the cbalint13:mslic branch from 3392514 to ce2fd8e Jan 11, 2017

@cbalint13

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2017

@sovrasov ,

  • All done as requested.
@sovrasov
Copy link
Contributor

left a comment

👍

@alalek alalek merged commit 6891d77 into opencv:master Jan 11, 2017

1 check passed

default Required builds passed
Details

@cbalint13 cbalint13 deleted the cbalint13:mslic branch Jan 12, 2017

@JunMa11

This comment has been minimized.

Copy link

commented May 17, 2017

Would it be possible for you to provide MALTAB version of the code?

@cbalint13

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2017

@EdwardMa12593 ,

  • Original code was C++ .
  • You can ask the very author (e-mail) regarding if he have matlab .

Personally can't help with matlab code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.