Skip to content

added BackgroundSubtractorCNT - #994

Merged
alalek merged 3 commits into
opencv:masterfrom
lhelontra:BackgroundSubtractorCNT
Mar 10, 2017
Merged

added BackgroundSubtractorCNT#994
alalek merged 3 commits into
opencv:masterfrom
lhelontra:BackgroundSubtractorCNT

Conversation

@lhelontra

Copy link
Copy Markdown
Contributor

New background subtraction solution, very fast compared with mog2 or Knn. Good solution for low spec hardware. For more details, see: https://www.theimpossiblecode.com/blog/fastest-background-subtraction-opencv/

@sovrasov

sovrasov commented Mar 3, 2017

Copy link
Copy Markdown
Contributor

👍

@alalek alalek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is link for generated documentation with this patch.


//! @}

/** @brief Background subtraction based on counting.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put code below before this line above:

//! @}

It is required for proper documentation generation.

Comment thread modules/bgsegm/src/bgfg_subcnt.cpp Outdated

/** @brief Implementation of background subtraction based on counting.
* About as fast as MOG2 on a high end system (benchmarked on )
* More than twice faster than MOG2 on cheap hardware (benchmarked on Raspberry Pi3).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of comment is a "duplication" of comment from .hpp file. Probably it is better to fix it or eliminate duplication.

BTW, this comment is not a part of auto-generated documentation.

Comment thread modules/bgsegm/src/bgfg_subcnt.cpp Outdated
* @param useHistory determines if we're giving a pixel credit for being stable for a long time
* @param maxStability maximum allowed credit for a pixel in history
* @param isParallel determines if we're parallelizing the algorithm
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation comment should be moved into .hpp file for createBackgroundSubtractorCNT function.

@lhelontra

Copy link
Copy Markdown
Contributor Author

@alalek Thanks for your suggestions.

@alalek
alalek merged commit de34d70 into opencv:master Mar 10, 2017
@sagi-z

sagi-z commented Jul 24, 2017

Copy link
Copy Markdown

Hi guys,
I'm the author of this code.
It is great that you're inserting my implementation here.

Just one request - please restore this line to the class documentation comment (deleted in the merge):
Algorithm by Sagi Zeevi

(see here : https://github.com/sagi-z/BackgroundSubtractorCNT/blob/master/bgsubcnt.h)

Thanks!

@alalek

alalek commented Jul 24, 2017

Copy link
Copy Markdown
Member

@sagi-z Patch: #1290 (docs preview)

@sagi-z

sagi-z commented Jul 24, 2017

Copy link
Copy Markdown

@alalek It looks okay now. Thanks for the quick response.

kallaballa pushed a commit to kallaballa/Plan-V4D that referenced this pull request Sep 1, 2026
* added BackgroundSubtractorCNT

* doc fixes

* fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants