added BackgroundSubtractorCNT #994
Conversation
|
👍 |
|
|
||
| //! @} | ||
|
|
||
| /** @brief Background subtraction based on counting. |
There was a problem hiding this comment.
Please put code below before this line above:
//! @}
It is required for proper documentation generation.
modules/bgsegm/src/bgfg_subcnt.cpp
Outdated
|
|
||
| /** @brief Implementation of background subtraction based on counting. | ||
| * About as fast as MOG2 on a high end system (benchmarked on ) | ||
| * More than twice faster than MOG2 on cheap hardware (benchmarked on Raspberry Pi3). |
There was a problem hiding this comment.
This part of comment is a "duplication" of comment from .hpp file. Probably it is better to fix it or eliminate duplication.
BTW, this comment is not a part of auto-generated documentation.
modules/bgsegm/src/bgfg_subcnt.cpp
Outdated
| * @param useHistory determines if we're giving a pixel credit for being stable for a long time | ||
| * @param maxStability maximum allowed credit for a pixel in history | ||
| * @param isParallel determines if we're parallelizing the algorithm | ||
| */ |
There was a problem hiding this comment.
This documentation comment should be moved into .hpp file for createBackgroundSubtractorCNT function.
|
@alalek Thanks for your suggestions. |
|
Hi guys, Just one request - please restore this line to the class documentation comment (deleted in the merge): (see here : https://github.com/sagi-z/BackgroundSubtractorCNT/blob/master/bgsubcnt.h) Thanks! |
|
@sagi-z Patch: #1290 (docs preview) |
|
@alalek It looks okay now. Thanks for the quick response. |
New background subtraction solution, very fast compared with mog2 or Knn. Good solution for low spec hardware. For more details, see: https://www.theimpossiblecode.com/blog/fastest-background-subtraction-opencv/