Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle ping response and api call #207

Merged
merged 4 commits into from Nov 19, 2019
Merged

Fix bundle ping response and api call #207

merged 4 commits into from Nov 19, 2019

Conversation

mdazam1942
Copy link
Member

  1. Ping didn't return correct status. Making a head call to bundle url to get the correct response
  2. Empty Auth object was used to make api call which was failing on Github redirected address. It will also now avoid using auth(username/password) params if username/password is null.

@mdazam1942 mdazam1942 merged commit 5a0594c into master Nov 19, 2019
@emishas emishas deleted the defect_1226 branch November 19, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants