Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

results metadata support #813

Merged
merged 8 commits into from Mar 24, 2022
Merged

results metadata support #813

merged 8 commits into from Mar 24, 2022

Conversation

yurii-klymenko
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #813 (3ece3a3) into develop (483a290) will decrease coverage by 0.03%.
The diff coverage is 38.46%.

@@             Coverage Diff             @@
##           develop     #813      +/-   ##
===========================================
- Coverage    63.52%   63.49%   -0.04%     
===========================================
  Files          468      468              
  Lines        41671    41700      +29     
===========================================
+ Hits         26472    26477       +5     
- Misses       15199    15223      +24     
Impacted Files Coverage Δ
...ifter_modules/proxy/stix_transmission/connector.py 0.00% <0.00%> (ø)
...s/base/stix_transmission/base_results_connector.py 26.92% <18.18%> (-11.97%) ⬇️
...s/modules/base/stix_transmission/base_connector.py 37.83% <25.00%> (-10.44%) ⬇️
stix_shifter_utils/utils/base_entry_point.py 73.35% <55.55%> (-0.59%) ⬇️
...tix_shifter/stix_transmission/stix_transmission.py 81.31% <58.33%> (-3.39%) ⬇️
...us_template/stix_transmission/results_connector.py 74.07% <66.66%> (-1.93%) ⬇️
...es/base/stix_transmission/base_status_connector.py 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483a290...3ece3a3. Read the comment docs.

@yurii-klymenko yurii-klymenko marked this pull request as ready for review March 21, 2022 19:29
#METADATA_SAMPLE else:
#METADATA_SAMPLE metadata = {}
#METADATA_SAMPLE metadata_result_id += 1
#METADATA_SAMPLE metadata['metadata_result_id'] = metadata_result_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand this usage-

  1. what is the use of metadata_result_id?
  2. why does it have to be integer?
  3. why are you incrementing the id?
  4. what if there's a different key other than metadata_result_id?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is just a sample, any data can be returned in metadata status. That returned metadata will be provided to future status and results calls.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, this example would confuse people. Also, I would put example inside dummy connectors instead of stix-bundle stix_shifter_modules/synchronous_dummy / stix_shifter_modules/async_dummy

@mdazam1942 mdazam1942 merged commit 9fd3284 into develop Mar 24, 2022
@mdazam1942 mdazam1942 deleted the results_metadata_support branch March 24, 2022 15:26
delliott90 pushed a commit that referenced this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants