New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNWIND CIP #230

Open
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Mats-SX
Member

Mats-SX commented Apr 24, 2017

CIP

@Mats-SX Mats-SX added the CIP label Apr 24, 2017

Mats-SX added some commits May 15, 2017

Create proper UNWIND feature
All language features should be properly grouped into TCK features, with
only relevant scenarios in each. Currently many TCK features contain
a varied set of scenarios -- these are conventionally named
*Acceptance.feature and have a historical background as Neo4j
acceptance tests. Curated TCK features use another naming convention,
and this commit provides an improvement in this area.
@Mats-SX

This comment has been minimized.

Member

Mats-SX commented May 22, 2017

Extended CIP to also include OPTIONAL UNWIND from #234.

Note on TCK impact of this PR:
All language features should be properly grouped into TCK features, with only relevant scenarios in each. Currently many TCK features contain a varied set of scenarios -- these are conventionally named *Acceptance.feature and have a historical background as Neo4j acceptance tests. Curated TCK features use another naming convention, and this PR provides an improvement in this area.

For OPTIONAL UNWIND I simply copied the TCK feature of UNWIND and modified the queries to use OPTIONAL UNWIND. This resulted in several scenarios which exemplify standard UNWIND semantics. Happy to discuss whether this approach is a good idea, or whether the OPTIONAL UNWIND scenarios only should consider cases using empty lists or null.

Mats-SX and others added some commits May 22, 2017

Fix scenarios with misspelled steps
Override default messaging for undefined steps in Cucumber integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment