New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CIP #9

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@pontusmelke

pontusmelke commented Oct 26, 2015

Something went wrong with the old PR when moving repo. Please kill the old one when all relevant comments have been moved over.

@pontusmelke pontusmelke changed the title from Create cip to Create CIP Oct 26, 2015

@systay systay referenced this pull request Oct 27, 2015

Closed

Create CIP #5

== Proposal
`CREATE` is used to create new nodes and relationships into the graph, as well as set initial labels, type, and properties on the new entities.

This comment has been minimized.

@petraselmer

petraselmer Oct 27, 2015

Contributor

"create new nodes and relationships into the graph" -> "add new nodes and relationships to the graph"

@nawroth

This comment has been minimized.

in-rel = "<-[", [identifier], type, [property], "]-" ;
label = ":", identifier ;
type = label ;
property = "{", param | {identifier, ":", literal | param}, "}" ;

This comment has been minimized.

@thobe

thobe Nov 9, 2015

Contributor

the param production already contains the "{" and "}", and should this be on the "top level" of the property production.

This comment has been minimized.

@Mats-SX

Mats-SX Nov 9, 2015

Member

I do not understand what you mean.

----
create = "CREATE", {pattern}, [{",", pattern}] ;
pattern = node-pattern | rel-pattern ;
node-pattern = "(", [identifier], [{label}], [property], ")" ;

This comment has been minimized.

@thobe

thobe Nov 9, 2015

Contributor

What do the curly brackets around {label} mean here?

This comment has been minimized.

@Mats-SX

Mats-SX Nov 9, 2015

Member

Repetition, ie many possible labels.

This comment has been minimized.

@petraselmer

petraselmer Sep 27, 2016

Contributor

Contingent on the enhanced pattern semantics idea.

@petraselmer

This comment has been minimized.

Contributor

petraselmer commented Jan 17, 2018

The title needs to be changed: "CIP2015-10-12 - CREATE" -> "CIP2015-10-12 CREATE"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment