Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate CIP #9
Conversation
pontusmelke
and others
added some commits
Oct 12, 2015
pontusmelke
changed the title from
Create cip
to
Create CIP
Oct 26, 2015
petraselmer
reviewed
Oct 27, 2015
cip/CIP2015-10-12-CREATE.adoc
Outdated
| == Proposal | ||
| `CREATE` is used to create new nodes and relationships into the graph, as well as set initial labels, type, and properties on the new entities. |
This comment has been minimized.
This comment has been minimized.
petraselmer
Oct 27, 2015
Contributor
"create new nodes and relationships into the graph" -> "add new nodes and relationships to the graph"
This comment has been minimized.
This comment has been minimized.
nawroth
commented
Oct 28, 2015
thobe
reviewed
Nov 9, 2015
| in-rel = "<-[", [identifier], type, [property], "]-" ; | ||
| label = ":", identifier ; | ||
| type = label ; | ||
| property = "{", param | {identifier, ":", literal | param}, "}" ; |
This comment has been minimized.
This comment has been minimized.
thobe
Nov 9, 2015
Contributor
the param production already contains the "{" and "}", and should this be on the "top level" of the property production.
This comment has been minimized.
This comment has been minimized.
thobe
reviewed
Nov 9, 2015
| ---- | ||
| create = "CREATE", {pattern}, [{",", pattern}] ; | ||
| pattern = node-pattern | rel-pattern ; | ||
| node-pattern = "(", [identifier], [{label}], [property], ")" ; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
petraselmer
added
the
CIP
label
Jun 20, 2016
petraselmer
added
the
NOT READY FOR MERGE
label
Sep 27, 2016
This comment has been minimized.
This comment has been minimized.
|
The title needs to be changed: "CIP2015-10-12 - CREATE" -> "CIP2015-10-12 CREATE" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pontusmelke commentedOct 26, 2015
Something went wrong with the old PR when moving repo. Please kill the old one when all relevant comments have been moved over.