Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Hours Endpoint Error #10

Closed
markjamesm opened this issue Oct 20, 2020 · 2 comments
Closed

Library Hours Endpoint Error #10

markjamesm opened this issue Oct 20, 2020 · 2 comments

Comments

@markjamesm
Copy link

Hi,

I've been receiving errors when attempting to access the library hours endpoint using today or yesterday's date:

https://opendata.concordia.ca/API/v1/library/hours/2020-10-20

Returns the following:

[{"service":"Webster Library","text":"7 PM to 7 PM"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"service":"Vanier Library","text":"7 PM to 7 PM"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"service":"Grey Nuns","text":"7 PM to 7 PM"}]

@volovikariel
Copy link
Contributor

volovikariel commented Apr 6, 2022

This seems to be working fine now, some endpoints may not be available, but almost all of them seem to work.

Maybe the API shouldn't return the error-only objects because it's hard to tell what they map to (which service). Or perhaps an object of this form should be used instead? {"service": "service_name", "text": "ERROR ..."}

I'm writing this as of April 6 2022, and I tested April 30 2022 (link: https://opendata.concordia.ca/API/v1/library/hours/2022-04-30).

[
{
"service": "Webster Library",
"text": "2 PM to 2 PM"
},
{
"service": "Reference Desk",
"text": "12 PM to 5 PM"
},
{
"service": "Loans and Returns",
"text": "10 AM to 5 PM"
},
{
"service": "Interlibrary Loans",
"text": "2 PM to 2 PM"
},
{
"service": "Technology Sandbox",
"text": "2 PM to 2 PM"
},
{
"service": "Vanier Library",
"text": "2 PM to 2 PM"
},
{
"service": "Special Collections",
"text": "2 PM to 2 PM"
},
{
"Error": "Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"
}
]

@opendataConcordiaU
Copy link
Owner

Yes, this is seems to working fine. Closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants