Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset add `--match-rules` option, is it still needed? #447

Kirill888 opened this issue May 15, 2018 · 0 comments


Copy link

commented May 15, 2018

It's not super clear how to use it and who is using it. It is not being tested by our integration tests.

Reading code it seems to be something like:

Rather than using product definition from the database load them from file

It's unclear exactly how different definitions in the "rules files" can be from what's in database. I do not see reasonable use cases for this option. I propose we remove it.

Kirill888 added a commit that referenced this issue May 16, 2018

@Kirill888 Kirill888 closed this May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.