Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elyra to list of notebooks available for ODH #171

Merged
merged 4 commits into from Aug 28, 2020

Conversation

akchinSTC
Copy link
Contributor

  • Adds Elyra build configs and Imagestream

Will need to rebase images to official ones in dockerhub when they get published

- Adds Elyra build configs and Imagestream
@openshift-ci-robot
Copy link
Collaborator

Hi @akchinSTC. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Collaborator

Hi @akchinSTC. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crobby
Copy link
Contributor

crobby commented Aug 24, 2020

/ok-to-test

@vpavlin
Copy link
Contributor

vpavlin commented Aug 24, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Hold off on merging (provide reason in comment) label Aug 24, 2020
- removed elyra from jh profiles
- updated image names and references to new remain consistent with odh elyra image repo
- updated base image used in build config and version numbers
@vpavlin
Copy link
Contributor

vpavlin commented Aug 26, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Hold off on merging (provide reason in comment) label Aug 26, 2020
@vpavlin vpavlin self-requested a review August 26, 2020 16:41
@vpavlin
Copy link
Contributor

vpavlin commented Aug 26, 2020

/lgtm

@vpavlin
Copy link
Contributor

vpavlin commented Aug 27, 2020

/retest

openshift.io/imported-from: quay.io/thoth-station/s2i-lab-elyra
from:
kind: DockerImage
name: quay.io/thoth-station/s2i-lab-elyra:v0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akchinSTC I have merged your PR in s2i-lab-elyra repo..Would you please make one last change - replace version v0.0.1 with v0.0.2 and I think we are ok to merge

@crobby
Copy link
Contributor

crobby commented Aug 27, 2020

/test all
ci system continues to flake

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akchinSTC
To complete the pull request process, please assign vpavlin
You can assign the PR to them by writing /assign @vpavlin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akchinSTC
To complete the pull request process, please assign vpavlin
You can assign the PR to them by writing /assign @vpavlin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crobby
Copy link
Contributor

crobby commented Aug 27, 2020

/test all

@openshift-ci-robot
Copy link
Collaborator

@akchinSTC: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/odh-manifests-e2e 0f3f33e link /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vpavlin
Copy link
Contributor

vpavlin commented Aug 28, 2020

/lgtm

@vpavlin vpavlin merged commit 5e2d0b0 into opendatahub-io:master Aug 28, 2020
1 of 3 checks passed
@vpavlin vpavlin moved this from In progress to Done in ODH 0.9.0 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
ODH 0.9.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants