Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 440 Fix change password url generation #441

Conversation

Projects
None yet
6 participants
@ggalmazor
Copy link
Member

commented Mar 11, 2019

Closes #440

What has been done to verify that this works as intended?

Launches as non-ROOT webapp in a local tomcat server and changed the password while inspecting the network tab using Chrome's developer console.

Why is this the best possible solution? Were any other approaches considered?

This fixes the issue like in 048410e

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

No.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No.

@ggalmazor ggalmazor added this to the v2.0.2 milestone Mar 11, 2019

@ggalmazor ggalmazor requested a review from dcbriccetti Mar 11, 2019

@zwets

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

I just tested this by replacing only the SecurityServiceImpl.class in my deployed war and can confirm the issue is solved here.

@yanokwa yanokwa merged commit e205691 into opendatakit:master Mar 12, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@ggalmazor ggalmazor deleted the ggalmazor:issue_440_fix_change_password_url_generation branch Mar 12, 2019

@kkrawczyk123

This comment has been minimized.

Copy link

commented Mar 14, 2019

I've tested changing superuser and user passwords, everything worked great for me!
@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.