Make Spinner widget open from start-of-list when nothing is selected #1955
Conversation
|
|
||
| /** | ||
| * Created by vaibhav on 1/3/18. | ||
| */ |
There was a problem hiding this comment.
Please replace this comment with a description of the class. The very top should have a copyright notice with your name (you are the copyright holder) -- https://github.com/opendatakit/collect/blob/master/LICENSE.md#appendix-how-to-apply-the-apache-license-to-your-work
| * Created by vaibhav on 1/3/18. | ||
| */ | ||
|
|
||
| public class CustomSpinner extends AppCompatSpinner { |
There was a problem hiding this comment.
What would a more descriptive name be? How about ScrolledToTopSpinner or something like that?
|
|
||
| public class CustomSpinner extends AppCompatSpinner { | ||
|
|
||
| private boolean toggleFlag = true; |
There was a problem hiding this comment.
This should also have a more descriptive name. I would call it spinnerClicked and have it start as false. It's confusing that the condition in getSelectedItemPosition is negated.
|
Thank You @lognaturel for suggestions. I have made the required changes. |
|
I have no idea why build_debug is failing on CircleCI. The logs aren't helpful either. Can you please point out any errors? |
|
Tested with success! Verified on Android: 4.1, 4.2, 4.4, 5.1, 6.0, 7.0, 8.0. Verified cases:
New, related issue was created - #1960 @opendatakit-bot unlabel "needs testing" |
getodk-bot
added
behavior verified
reviewed
and removed
needs testing
needs review
labels
|
Thanks, @iammvaibhav! The failure was due to the continuous integration server running out of memory. I simply re-ran it and it passed. |
Closes #1935
What has been done to verify that this works as intended?
Used the form for testing provided In the Issue
Why is this the best possible solution? Were any other approaches considered?
AppCompatSpinner by default doesn't provide such functionality, so in order to achieve this, extending AppCompatSpinner was must.
Are there any risks to merging this code? If so, what are they?
I don't think so.
Do we need any specific form for testing your changes? If so, please attach one.
selectOneMinimal.xml.txt