Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests against a local piwik instance - fix #24 #28

Merged
merged 11 commits into from Dec 19, 2017

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Dec 14, 2017

Some basic testing of views and downloads count and aggregation.

Next steps: #22 and #23.

@abulte abulte requested a review from a team December 14, 2017 13:46
Copy link
Contributor

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌 but the docker-compose.yml is missing (this is why I asked for changes).

Optionnal: make the client a fixture to avoir imports

RESET_URL = '{0}/reset.php'.format(BASE_URL)


@retry(stop_max_attempt_number=20, wait_fixed=500)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this,I was looking for something like that 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@@ -0,0 +1,48 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid relative import, I think client can become a class into conftest.py available as a fixture

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. I can live with that for now though ;-)

@abulte
Copy link
Contributor Author

abulte commented Dec 14, 2017

@noirbizarre I put the docker-compose.yml file in https://github.com/opendatateam/udata-piwik-docker. Which when I did the PR seemed logical since the image was not available on docker hub. Now that it is, I certainly should put it here...

@abulte abulte mentioned this pull request Dec 14, 2017
@abulte abulte merged commit e906226 into opendatateam:master Dec 19, 2017
@abulte abulte deleted the features/integration-tests branch December 19, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants