New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests against a local piwik instance - fix #24 #28
Tests against a local piwik instance - fix #24 #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌 but the docker-compose.yml
is missing (this is why I asked for changes).
Optionnal: make the client a fixture to avoir imports
RESET_URL = '{0}/reset.php'.format(BASE_URL) | ||
|
||
|
||
@retry(stop_max_attempt_number=20, wait_fixed=500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this,I was looking for something like that 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
@@ -0,0 +1,48 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid relative import, I think client
can become a class into conftest.py
available as a fixture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. I can live with that for now though ;-)
@noirbizarre I put the |
Some basic testing of views and downloads count and aggregation.
Next steps: #22 and #23.