Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear datasets only after successful request #3

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

maudetes
Copy link
Contributor

@maudetes maudetes commented Feb 6, 2024

It prevents removing existing extras on a temporary failure.

Copy link
Contributor

@ThibaudDauce ThibaudDauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird you had to make all these changes not related to your PR for the CI to pass…

@maudetes
Copy link
Contributor Author

maudetes commented Feb 6, 2024

Weird you had to make all these changes not related to your PR for the CI to pass…

Last commit dates back from 2 years.
There has been breaking changes in setuptools, see opendatateam/udata#2813. We should fix it in opendatateam/udata#2859.
I've also upgraded dev & test deps as I was around.

@maudetes maudetes merged commit a5b93ea into main Feb 6, 2024
1 check passed
@maudetes maudetes deleted the fix/clear-datasets-after-requests branch February 6, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants