Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent js crash for geometryless zones #1188

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Oct 2, 2017

This PRs properly serialize geometryless zones into an empty MultiPolygon and prevent leaflet from crashing when computing boundaries.

Fix etalab/udata-gouvfr#221

@noirbizarre noirbizarre added the bug label Oct 2, 2017

@noirbizarre noirbizarre added this to the 1.2.0 milestone Oct 2, 2017

@noirbizarre noirbizarre requested a review from opendatateam/etalab Oct 2, 2017

@noirbizarre noirbizarre force-pushed the noirbizarre:gouvfr-221-prevent-js-crash-for-geometryless-zones branch from 6b6560a to 76b69d9 Oct 2, 2017

@abulte

abulte approved these changes Oct 2, 2017

Copy link
Member

left a comment

🎉

@noirbizarre noirbizarre merged commit 63c534f into opendatateam:master Oct 2, 2017

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:gouvfr-221-prevent-js-crash-for-geometryless-zones branch Oct 2, 2017

@noirbizarre noirbizarre removed the in progress label Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.