New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing spinners on most datatables #1401

Merged
merged 2 commits into from Jan 26, 2018

Conversation

Projects
None yet
2 participants
@taniki
Member

taniki commented Jan 26, 2018

loading prop was never undefined cf commit 5f8204c message for vue issue and test case

replace #1399
fix #1321

@taniki taniki added the in progress label Jan 26, 2018

@taniki taniki requested a review from opendatateam/etalab Jan 26, 2018

@abulte

abulte approved these changes Jan 26, 2018

👏 CHANGELOG?

@taniki taniki merged commit 64459d5 into opendatateam:master Jan 26, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre referenced this pull request Feb 5, 2018

Merged

Backport 1.2 #1417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment