New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes on search #1410

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Member

noirbizarre commented Jan 30, 2018

This PR apply small fixes on search:

  • facets right counters are vertically centered and ensure they do not overlap with text
  • differentiate the "more result button": centered and no more right picto (which as the same as facet header)
  • fix the missing separator between the initial facet result and the extra ones
  • remove the hardcoded white background color, just reuse the body color

Unexpanded

Before After
screenshot-data xps-2018-01-29-21-43-31-554 screenshot-data xps-2018-01-29-21-40-49-236

Expanded

Before After
screenshot-data xps-2018-01-29-21-43-57-495 screenshot-data xps-2018-01-29-21-41-24-353

@noirbizarre noirbizarre added this to the 1.3.0 milestone Jan 30, 2018

@noirbizarre noirbizarre self-assigned this Jan 30, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Jan 30, 2018

noirbizarre added a commit to noirbizarre/udata-gouvfr that referenced this pull request Jan 30, 2018

noirbizarre added a commit to noirbizarre/udata-gouvfr that referenced this pull request Jan 30, 2018

@taniki

taniki approved these changes Jan 30, 2018

.list-group-item {
// Fix the badge position on long facet labels
&:not(.more) {
@padding:15px; // Hard coded in bootstrap list-group compoent

This comment has been minimized.

@taniki

taniki Jan 30, 2018

Member

small typo here compo+n+ent

@noirbizarre noirbizarre merged commit 27f50ac into opendatateam:master Jan 30, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:search-fixes branch Jan 30, 2018

@noirbizarre noirbizarre referenced this pull request Feb 2, 2018

Merged

Style search page #36

noirbizarre added a commit to noirbizarre/udata-gouvfr that referenced this pull request Feb 5, 2018

@noirbizarre noirbizarre referenced this pull request Feb 5, 2018

Merged

Backport 1.2 #1417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment