New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown soft breaks as new lines and client-side security #1432

Merged
merged 2 commits into from Feb 12, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Member

noirbizarre commented Feb 12, 2018

This PR:

  • handles markdown softbreaks as new lines as allowed by commonmark specifications
  • adds some test to the client-side rendering
  • make both backend and client side share the same configuration
  • handle html sanitization in client side

@noirbizarre noirbizarre added this to the 1.3.0 milestone Feb 12, 2018

@noirbizarre noirbizarre self-assigned this Feb 12, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Feb 12, 2018

@abulte

abulte approved these changes Feb 12, 2018

@noirbizarre noirbizarre merged commit 320e9ca into opendatateam:master Feb 12, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:markdown-tests branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment