Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send Dataset.on_save signal on linkchecking #1643

Merged
merged 5 commits into from May 4, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented May 3, 2018

This PR fix bug on the linkchecker creating activities each time an user visit a page as a side-effect of checking resources (even with the default linkchecker).

⚠️ The fix comes with a migration dropping all "dataset updated" activities because they were not relevant before this PR.

@noirbizarre noirbizarre force-pushed the noirbizarre:prevent-signal-dispatch branch from a2877a3 to c6aec0e May 4, 2018

@noirbizarre noirbizarre changed the base branch from master to 1.3 May 4, 2018

@noirbizarre noirbizarre changed the title WIP: Do not send Dataset.on_save signal on linkchecking Do not send Dataset.on_save signal on linkchecking May 4, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab May 4, 2018

@noirbizarre noirbizarre added this to the 1.3.9 milestone May 4, 2018

@abulte

abulte approved these changes May 4, 2018

@noirbizarre noirbizarre merged commit 708b1aa into opendatateam:1.3 May 4, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:prevent-signal-dispatch branch May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.