Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified date range display on cards and search results #1833

Merged

Conversation

@noirbizarre
Copy link
Member

commented Aug 17, 2018

This PR simplifies date rande display on cards by only displaying years. Dataset admin details and page are left unchanged (with details).

Server-side card

screenshot-data xps-2018 08 17-18-10-41

Client-side cards

screenshot-data xps-2018 08 17-18-10-04

Search results

screenshot-data xps-2018 08 17-18-11-54

Dataset page details

screenshot-data xps-2018 08 17-18-11-07

Admin details

screenshot-data xps-2018 08 17-18-08-56

Supersedes #1392

@noirbizarre noirbizarre added this to the 1.6.0 milestone Aug 17, 2018
@noirbizarre noirbizarre self-assigned this Aug 17, 2018
@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 17, 2018
@noirbizarre noirbizarre force-pushed the noirbizarre:enhancement/daterange-yearly branch from 25a8b91 to 6aaf37e Aug 17, 2018
@taniki
taniki approved these changes Aug 17, 2018
@noirbizarre noirbizarre merged commit 7e50c34 into opendatateam:master Aug 17, 2018
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:enhancement/daterange-yearly branch Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.