Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure API doc works without data #1840

Merged

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Aug 21, 2018

This PR ensure that API doc works when there is not as many data as required to generate the code snippets by generating the missing data with the factories.

Search criterions have been removed: listing relies on global scoring (and allows to fetch organizations when there isn't a lot of data)

It also fixes some snippets (id vs slug)

Fixes #1787
Fixes #1741

@noirbizarre noirbizarre added this to the 1.6.0 milestone Aug 21, 2018

@noirbizarre noirbizarre self-assigned this Aug 21, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 21, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:gh#1787-api-doc-no-data branch 3 times, most recently from 3b4833b to f58dbde Aug 21, 2018

@noirbizarre noirbizarre changed the title Ensure API doc works without data (fix #1787) Ensure API doc works without data Aug 21, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:gh#1787-api-doc-no-data branch from f58dbde to 1e794c2 Aug 21, 2018

@taniki

taniki approved these changes Aug 22, 2018

@noirbizarre noirbizarre merged commit 137fb6a into opendatateam:master Aug 22, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:gh#1787-api-doc-no-data branch Aug 22, 2018

@noirbizarre noirbizarre referenced this pull request Aug 24, 2018

Merged

Backport 1.5 #1851

@noirbizarre noirbizarre modified the milestones: 1.6.0, 1.5.3 Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.