Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts workflow rework #1857

Merged
merged 12 commits into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Aug 27, 2018

This pull-request rework the post publication workflow.

Admin

Publication date and publish/unpublish API

The private boolean attribute has been replaced by a published datetime (migration provided).
The publication is now a separate action from the creation/edition (and so a separate API)

Unpublished state

screenshot-data xps-2018 08 25-19-54-10

screenshot-data xps-2018 08 28-11-55-18

Published state

screenshot-data xps-2018 08 25-19-52-21

screenshot-data xps-2018 08 27-17-35-27

Publish action in form and save without reload

User can now save the post and still continue editing. It can also publish the post from the form.

Unpublished state

screenshot-data xps-2018 08 25-19-57-38

Published state

screenshot-data xps-2018 08 25-20-04-49

Bigger textarea

Initial textarea size is 12 rows (to fit in the window). User can still grow the textarea or toggle fullscreen if more is required

screenshot-data xps-2018 08 27-14-55-59

Other admin fixes

Fixes broken reuses and datasets cards

Post layout

This pull-request provide bug fixes and enhancements on the post UI

Alignements fixes

Sidebar cards as well as pager are now properly aligned on the layout

screenshot-data xps-2018 08 25-19-38-16
screenshot-data xps-2018 08 25-19-13-44

Full width content instead of empty sidebar

When there is no content in the sidebar, the post content will grow to full-width avoid a big blank on the right

Pluralized sidebar sections

Sections titles are now pluralized. That means we have Associated dataset/Associated datasets and Associated reuse/Associated reuses.

Singular Plural
screenshot-data xps-2018 08 25-19-55-57 screenshot-data xps-2018 08 25-19-51-04

Translations needs to be updated.

Other changes

There is now a draft label on unpublished posts

screenshot-data xps-2018 08 25-20-02-58

The default theme now has a background color on pager to avoir a full blank page with floating buttons

screenshot-data xps-2018 08 27-15-06-33

@noirbizarre noirbizarre added this to the 1.6.0 milestone Aug 27, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 27, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:posts-rework branch from db6d9d7 to 2a8fbe4 Aug 27, 2018

@taniki

This comment has been minimized.

Copy link
Member

taniki commented Aug 27, 2018

  • not sure about the color of the two first modals. Both are a bit brutal
  • it is also the same colors than the buttons
  • buttons position should be switched (keep cancel on the left)
  • maybe keep yello buttons for cancel actions
  • not sure about "unpublication" as an actual word
@noirbizarre

This comment has been minimized.

Copy link
Member Author

noirbizarre commented Aug 27, 2018

  • not sure about the color of the two first modals. Both are a bit brutal

These are colors already used on other modals (warning and dangers). I choose to reuse existing classes and styles, but these can be changed in another PR (modal colors/classes admin-wide)

  • it is also the same colors than the buttons

Not sure to understand but same here, no style change to existing conventions in this. All buttons are using the same classes. We can change that but admin-wide in another PR. This PR focus on the workflow.
The only change is the buttons order, acted last week: Cancel/Back on left, actions on right.

  • buttons should be switched

I don't understand. Which one ? Switched from ? to ?

  • maybe keep yello buttons for cancel actions

This is already the case: the btn-warning class is only applyied to the Cancel/Back button

  • not sure about "unpublication" as an actual word

Yes it is, I checked for the commonly term before 👉 https://en.wiktionary.org/wiki/unpublication 😉
See also https://english.stackexchange.com/questions/2208/does-the-verb-unpublish-exist
This is the term used in most of the CMS and, most important,this is the term that people are looking for (There is even official tutos and videos from Wordpress, Adobe... using this term).
The problem is: the unpublication action wasn't possible before the CMS invention, so no, the word isn't present yet in all dictionnaries, but english speaking people are used to have un- words for reverse actions

@noirbizarre

This comment has been minimized.

Copy link
Member Author

noirbizarre commented Aug 27, 2018

NB: but I'm open to any other prefered alternative to unpublish but I wasn' able to find one

@noirbizarre noirbizarre force-pushed the noirbizarre:posts-rework branch from 37d9fc9 to d3b3b16 Aug 27, 2018

@noirbizarre

This comment has been minimized.

Copy link
Member Author

noirbizarre commented Aug 27, 2018

Cancel/Confirm buttons switched, screenshots updated

@noirbizarre noirbizarre force-pushed the noirbizarre:posts-rework branch from d3b3b16 to 8bb8a57 Aug 27, 2018

@noirbizarre

This comment has been minimized.

Copy link
Member Author

noirbizarre commented Aug 27, 2018

Updated modals header wording (Publish/Unpublish).
PR description screenshots updated

@noirbizarre noirbizarre force-pushed the noirbizarre:posts-rework branch from 8bb8a57 to 3a3ec37 Aug 27, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:posts-rework branch from 3a3ec37 to eaa1e10 Aug 28, 2018

@noirbizarre

This comment has been minimized.

Copy link
Member Author

noirbizarre commented Aug 28, 2018

Publish modal Cancel button switched to outlined. Screenshot updated

@taniki

taniki approved these changes Aug 28, 2018

@noirbizarre noirbizarre merged commit a712164 into opendatateam:master Aug 28, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:posts-rework branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.