Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS everywhere #1866

Merged
merged 3 commits into from Sep 3, 2018

Conversation

Projects
None yet
3 participants
@noirbizarre
Copy link
Member

commented Sep 3, 2018

This pull request enable CORS handling on non-html pages:

  • RDFs views
  • CSVs views
  • resource redirect

(API was already handling CORS).

To do so, an optionnal cors=True parameter has been added to I18nBlueprint (which, by the way, could be extracted to become a UdataBlueprint)

@noirbizarre noirbizarre added this to the 1.6.0 milestone Sep 3, 2018

@noirbizarre noirbizarre self-assigned this Sep 3, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Sep 3, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:cors-everywhere branch from dc225be to 7240808 Sep 3, 2018

@abulte

abulte approved these changes Sep 3, 2018

@noirbizarre noirbizarre merged commit e5b80cd into opendatateam:master Sep 3, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:cors-everywhere branch Sep 3, 2018

@Fil

This comment has been minimized.

Copy link

commented Sep 18, 2018

Ca n'a pas encore été déployé ? Rien de changé ici en tout cas : https://beta.observablehq.com/d/246225bde056be33

@abulte

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

@Fil non pas encore, vous pouvez voir la version actuelle dans le footer de data.gouv.fr — ce changement sera présent à partir de la 1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.