Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources list wrapping #1893

Merged
merged 3 commits into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Sep 20, 2018

This PR fixes the resources list wrapping:

  • proper actions buttons wrapping
  • proper community resource anchor wrapping

Desktop

Before After
screenshot-data xps-2018 09 20-15-14-25 screenshot-data xps-2018 09 20-14-41-11

Large mobile (width > 320)

Before After
screenshot-data xps-2018 09 20-15-16-39 screenshot-data xps-2018 09 20-15-08-55

Small mobile (width <=320)

Before After
screenshot-data xps-2018 09 20-15-17-43 screenshot-data xps-2018 09 20-15-10-22

@noirbizarre noirbizarre added this to the 1.6.0 milestone Sep 20, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Sep 20, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:resources-list-wrapping branch from e61767e to 274a4ac Sep 20, 2018

@abulte

abulte approved these changes Sep 20, 2018

@noirbizarre noirbizarre merged commit ef7e96d into opendatateam:master Sep 20, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:resources-list-wrapping branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.