Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace label and action of button when format of resource is 'url' #1894

Merged
merged 5 commits into from Sep 24, 2018

Conversation

Projects
None yet
2 participants
@taniki
Copy link
Member

commented Sep 20, 2018

No description provided.

@noirbizarre
Copy link
Member

left a comment

I think this will only fix a very small subset because format is a free form field:

  • can be uppercased
  • there is a lot of dataset where the format for remote pages is html
  • there is a lot of dataset where the format for remote page is the format of the actual downloadable content.

A long term solution would be to handle resource like DCAT (where the is a dcat:landingPage attribute) and CKAN (where we can specify nested format ie. csv in zip)

@taniki

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2018

Hum. Can we then agree that all code repositories are link to webpages (and not to html file to download)?

@noirbizarre

This comment has been minimized.

Copy link
Member

commented Sep 21, 2018

Yes we can but don't worry I approved the PR.
I just wanted to give you some hints for later improvements.
Applying the same change to code repositories might be a another good PR.
Having a configurable list of format to open instead of download can be another.

taniki added some commits Sep 24, 2018

@taniki taniki merged commit 6b94814 into opendatateam:master Sep 24, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.