Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split harvest exceptions #1920

Merged
merged 3 commits into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Oct 15, 2018

This PR create a new HarvestValidationError exception to properly handle validation errors:

  • proper display in admin (no useless stacktrace, only the errors)
  • less stored data (no stacktrace)
  • no Sentry clutering (like this)

@noirbizarre noirbizarre added this to the 1.6.2 milestone Oct 15, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Oct 15, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:split-harvest-exceptions branch from 5defc38 to 2c16bd7 Oct 15, 2018

@abulte

abulte approved these changes Oct 15, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:split-harvest-exceptions branch from 2c16bd7 to c021280 Oct 15, 2018

@noirbizarre noirbizarre merged commit 0f9854b into opendatateam:master Oct 15, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:split-harvest-exceptions branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.