Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure image picker only allows image files #1925

Merged

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Oct 18, 2018

This ensure users won't be able to provide anything else than an image in the image picker, preventing both client and server-side errors.

Supported image types are restricted to: png, jpeg and webp

@noirbizarre noirbizarre added the bug label Oct 18, 2018

@noirbizarre noirbizarre added this to the 1.6.2 milestone Oct 18, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Oct 18, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:image-picker-only-allows-images branch from 8e66846 to cd2db8e Oct 18, 2018

Ensure image picker only allows image files
fixes WWW-DATAGOUVFR-A94

@noirbizarre noirbizarre force-pushed the noirbizarre:image-picker-only-allows-images branch from cd2db8e to dece6d6 Oct 18, 2018

@abulte

abulte approved these changes Oct 23, 2018

@noirbizarre noirbizarre merged commit b103027 into opendatateam:master Oct 23, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:image-picker-only-allows-images branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.