Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with supported browsers (IE11 馃槖) #1990

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Jan 23, 2019

This PR switch from babel-preset-es2105 to babel-preset-env to ensure compatibility with udata supported browsers.
The initial browser list is:

  • > 0.5%
  • last 2 versions (for auto updating browsers like chrome)
  • not ie <= 10 (support IE11+)
  • not ie_mob <= 11 (no IE Mobile support)
  • Firefox ESR (should fix some Firefox issue with ESR)
  • not bb <= 10 (no legacy blackberry brother support)
  • not op_mob <= 12.1 (no legacy opera mobile/mini support)

This could/should be replaced by the following list on more recent browserlist support (so newer babel-preset-env/@babel/preset-env):

  • > 0.5%
  • not dead
  • ie >= 11

NB: @babel/preset-env is already used in the webpack-4-vue-2 branch so browserlist might need an update.

@noirbizarre noirbizarre added this to the 1.6.3 milestone Jan 23, 2019

@noirbizarre noirbizarre requested a review from opendatateam/etalab Jan 23, 2019

@abulte

abulte approved these changes Jan 23, 2019

Copy link
Member

abulte left a comment

馃帀

@noirbizarre noirbizarre force-pushed the noirbizarre:ie11-compat branch from 04170fd to cce5028 Jan 23, 2019

@noirbizarre noirbizarre merged commit 40b895d into opendatateam:master Jan 23, 2019

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:ie11-compat branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.