Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource form, modal and workflow fixes #1991

Merged
merged 6 commits into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@noirbizarre
Copy link
Member

noirbizarre commented Jan 24, 2019

This PR improve resource form, modal and workfow handling:

  • Prevent multiple uploads when only one is expected (resource modals and workflow):
    • hide the drop zone and the file picker
    • disable drag and drop
  • Fixes the nested form reactivity (ensure buttons and layout changes on form change)
  • Ensure reactivity on the file fields readonly attribute
  • Fixes the visual indicator on file drop

Replacing a resource is now explicit with a new "Replace the file" button:

screenshot-data xps-2019 01 24-13-34-45

screenshot-data xps-2019 01 24-13-36-13

@noirbizarre noirbizarre added this to the 1.6.3 milestone Jan 24, 2019

@noirbizarre noirbizarre requested a review from opendatateam/etalab Jan 24, 2019

@noirbizarre noirbizarre force-pushed the noirbizarre:fix-drop-zone branch from dd43be5 to ed5d62e Jan 24, 2019

@abulte

abulte approved these changes Jan 24, 2019

@noirbizarre noirbizarre merged commit 59b93cb into opendatateam:master Jan 24, 2019

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:fix-drop-zone branch Jan 24, 2019

@bboulesteix

This comment has been minimized.

Copy link

bboulesteix commented on ed5d62e Jan 24, 2019

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.