Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectize fixes #1992

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Jan 25, 2019

This PR fixes:

  • fixes the selectize new entry style (lack margins)
  • fixes format completer
  • centralize selectize style into base-completer mixin

Selectize new entry lacking margins

Before

screenshot-data xps-2019 01 25-13-16-32

After

screenshot-data xps-2019 01 25-13-12-32

Format completer

Before

screenshot-data xps-2019 01 25-13-15-46

After

screenshot-data xps-2019 01 25-13-11-15

@noirbizarre noirbizarre added this to the 1.6.3 milestone Jan 25, 2019

@noirbizarre noirbizarre requested a review from opendatateam/etalab Jan 25, 2019

@noirbizarre noirbizarre force-pushed the noirbizarre:selectize-fixes branch from 9001fa1 to 4ae1c42 Jan 25, 2019

@abulte

abulte approved these changes Jan 25, 2019

Copy link
Member

abulte left a comment

🎉

@noirbizarre noirbizarre merged commit 4f6da9f into opendatateam:master Jan 25, 2019

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:selectize-fixes branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.