Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API errors handling and visual feedback for unauthorized actions #2005

Merged

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Jan 30, 2019

This PR:

  • ensures the default API error handler is used on every write API calls
  • improves the API error handler:
    • handles unkown errors, server-side erros, sentry ID...
    • dispatches notification
  • propagates the Form.readonly to the fields (ensure fields are readonly when they should)
  • hides disallowed organization actions to the editor members

@noirbizarre noirbizarre added this to the 1.6.3 milestone Jan 30, 2019

@noirbizarre noirbizarre requested a review from opendatateam/etalab Jan 30, 2019

@noirbizarre noirbizarre force-pushed the noirbizarre:gh1962-unauthorized-feedback branch from 8373810 to 81843e4 Jan 30, 2019

@abulte

abulte approved these changes Jan 30, 2019

@noirbizarre noirbizarre merged commit 30b6d8f into opendatateam:master Jan 30, 2019

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:gh1962-unauthorized-feedback branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.