Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search wording and icons consistency #2013

Merged
merged 2 commits into from Feb 1, 2019

Conversation

@noirbizarre
Copy link
Member

commented Jan 31, 2019

This PR ensures all searches (datasets, reuses and organizations have the same wording):

Use Followers everywhere instead of Stars sometimes.
Use the same icon everywhere

Bonus: order options are now sorted alphabetically

Datasets

screenshot-data xps-2019 01 31-17-36-20

Organizations

screenshot-data xps-2019 01 31-17-35-35

Reuses

screenshot-data xps-2019 01 31-17-34-31

@noirbizarre noirbizarre added this to the 1.6.3 milestone Jan 31, 2019
@noirbizarre noirbizarre requested a review from opendatateam/etalab Jan 31, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:search-wording branch from 07f80ca to 80e02d9 Jan 31, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:search-wording branch from 8c34215 to 80e02d9 Jan 31, 2019
@noirbizarre noirbizarre changed the title Search wording and picto consistency Search wording and icons consistency Jan 31, 2019
@abulte
abulte approved these changes Feb 1, 2019
@noirbizarre noirbizarre merged commit 2f57095 into opendatateam:master Feb 1, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:search-wording branch Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.