Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion and issue form fix #2045

Merged

Conversation

@noirbizarre
Copy link
Member

commented Feb 22, 2019

This PR fixes the admin discussion and issue modals form validation.
As these forms aren't Form components, the BaseForm mixin is broken here and the validation too.

This PR makes a manual validation and drop the BaseForm mixin on those two modals.

@noirbizarre noirbizarre added the bug label Feb 22, 2019
@noirbizarre noirbizarre requested a review from opendatateam/etalab Feb 22, 2019
@noirbizarre noirbizarre added this to the 1.6.5 milestone Feb 22, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:discussion-and-issue-form-fix branch from bcedd68 to 68d6b81 Feb 22, 2019
@abulte
abulte approved these changes Feb 22, 2019
Copy link
Member

left a comment

💪

@noirbizarre noirbizarre merged commit dacd47f into opendatateam:master Feb 23, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:discussion-and-issue-form-fix branch Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.