Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up uploader errors - fix #2101 #2102

Merged
merged 3 commits into from Apr 11, 2019

Conversation

@abulte
Copy link
Member

commented Apr 10, 2019

Renaming on_error in the uploader prevents the parent form from redefining the callback and wrongly handling the errors.

Setting the resource to {} by default prevents some warning on first resource modal load.

There's still a problem where the error message does not display the valid extensions. But if I fix that some other error arise (the request is actually sent, another message displayed... 馃槕), so I'll leave that for later.

Capture d'茅cran 2019-04-10 15 52 50

abulte added 2 commits Apr 10, 2019
@abulte abulte requested a review from opendatateam/etalab Apr 10, 2019
@abulte abulte added this to the 1.6.7 milestone Apr 10, 2019
@abulte abulte added admin bug labels Apr 10, 2019
@abulte abulte merged commit aac58c8 into opendatateam:master Apr 11, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@abulte abulte deleted the abulte:fix/resource-upload-errors branch Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.