Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics cleanup #2113

Merged
merged 11 commits into from May 2, 2019

Conversation

@noirbizarre
Copy link
Member

commented Apr 24, 2019

This PR cleanup and tune metrics:

  • Breaks circular imports/dependencies
  • Removed the unuse data constructor parameter
  • Drop all exec_js/eval calls which are causing database read-write lock (see eval write lock documentation and replace them by aggregations
  • Use the right udata.tasks @task decorator
  • Use the native Python logger instead of the celery one
  • Migrate tests to pytest
  • Add more tests (and apply required fixes)
@noirbizarre noirbizarre added this to the 1.6.7 milestone Apr 24, 2019
@noirbizarre noirbizarre requested a review from opendatateam/etalab Apr 24, 2019
@abulte
abulte approved these changes May 2, 2019
udata/core/metrics/signals.py Outdated Show resolved Hide resolved
udata/core/metrics/specs.py Outdated Show resolved Hide resolved
udata/core/metrics/specs.py Outdated Show resolved Hide resolved
udata/core/metrics/specs.py Outdated Show resolved Hide resolved
udata/core/metrics/specs.py Outdated Show resolved Hide resolved
noirbizarre added 11 commits Apr 23, 2019
…rcular dependency
…sks decorator, logging and imports
…equired)
@noirbizarre noirbizarre force-pushed the noirbizarre:metrics-cleanup branch from 80a6312 to 95816ed May 2, 2019
@noirbizarre noirbizarre merged commit d7dadaa into opendatateam:master May 2, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:metrics-cleanup branch May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.