Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user slug to dataset cache key #2146

Merged
merged 2 commits into from May 15, 2019

Conversation

@abulte
Copy link
Member

commented May 15, 2019

This will avoid having a "Modify" button written into cache for unprivileged users, or no button appearing for admin users. The majority of the cache keys should be with anonymous, thus preserving the efficiency of the cache 馃.

@abulte abulte requested a review from taniki May 15, 2019
@taniki
taniki approved these changes May 15, 2019
@abulte abulte merged commit 0df8cb6 into opendatateam:master May 15, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@abulte abulte deleted the abulte:fix/dataset-cache-key branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.