Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix discussions UI #2190

Merged
merged 18 commits into from Jul 23, 2019

Conversation

@taniki
Copy link
Member

commented Jun 6, 2019

  • glitch when message is short
  • missing pagination
  • restore deep links
  • substitute ad-hoc js code to swagger.js model

FIX #2061

UI

image

@taniki taniki changed the title fix discussions [wip] fix discussions Jun 6, 2019
@taniki

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

deeplinks are kind of broken but I have no easy fix right now.

@taniki taniki changed the title [wip] fix discussions fix discussions Jun 6, 2019
@taniki

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

SOLVE #2061

@taniki taniki requested a review from opendatateam/etalab Jun 10, 2019
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
@abulte abulte changed the title fix discussions WIP: fix discussions Jun 21, 2019
@taniki

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

cf description. I have given some thoughts about this part of UI and pagination will be better on top.

@taniki

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Removing the "part of organisation" badge. Opening an issue about API and feasibility for later.

@taniki taniki force-pushed the taniki:fix/discussions branch from c79c2e6 to 9c9a782 Jul 11, 2019
taniki added 2 commits Jul 11, 2019
@taniki taniki requested a review from abulte Jul 11, 2019
@taniki taniki changed the title WIP: fix discussions fix discussions UI Jul 11, 2019
@taniki taniki requested review from opendatateam/etalab and removed request for abulte Jul 11, 2019
@abulte
abulte approved these changes Jul 11, 2019
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
taniki added 3 commits Jul 11, 2019
@taniki taniki merged commit 9262b14 into opendatateam:master Jul 23, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.