Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite last_update field if manually set #2220

Merged

Conversation

@noirbizarre
Copy link
Member

commented Jul 1, 2019

This PR prevent automatic last_update overwrite when it has been manually set.

Harvesting now rely on the same last_update handling (was also overwritten in BaseHarvester) and so benefit from this change.

Fix #2111

@noirbizarre noirbizarre requested a review from opendatateam/etalab Jul 1, 2019
Fix #2111
@noirbizarre noirbizarre force-pushed the noirbizarre:gh2111-harvest-last-update branch from a93c5ce to f6cb9fb Jul 1, 2019
@abulte
abulte approved these changes Jul 1, 2019
@noirbizarre noirbizarre merged commit d739918 into opendatateam:master Jul 1, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:gh2111-harvest-last-update branch Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.