Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEmbed card for organization #2273

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@noirbizarre
Copy link
Member

commented Aug 6, 2019

This PR adds OEmbed support for organizations.

As Datasets and Reuses, the oembed is simply the organization card rendered. The URLs have to be absolute in order to work embedded outside udata (so external=True is given as url_for parameter in the org card template):

screenshot-localhost_8080-2019 08 06-15_18_49

@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 6, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:orgs-oembed branch from 35e65b8 to 0d956f8 Aug 6, 2019
@abulte
abulte approved these changes Aug 6, 2019
@noirbizarre noirbizarre force-pushed the noirbizarre:orgs-oembed branch from 0d956f8 to 3377abf Aug 6, 2019
@noirbizarre noirbizarre merged commit dc7e72c into opendatateam:master Aug 6, 2019
3 checks passed
3 checks passed
ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details
@noirbizarre noirbizarre deleted the noirbizarre:orgs-oembed branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.