This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Change the default response format to JDBC. #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
approved these changes
Jan 3, 2020
|
|
||
| import java.util.Optional; | ||
|
|
||
| import static org.junit.Assert.*; |
| * @param requestParams request params. | ||
| * @return return true if the response required pretty format, otherwise return false. | ||
| */ | ||
| public static Boolean isPrettyFormat(Map<String, String> requestParams) { |
This was referenced Jan 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#159
Description of changes:
Problem Statement
Currently, By default the plugin returns original response from Elasticsearch in JSON. There are two major problmes with this format. (1) Not all the SQL query can translated to Elasticsearch DSL directly, so, the post processing logic is required. e.g.,SELECT LOG(MAX(FlightDelayMin)) FROM kibana_sample_data_flights. In this case, the log should be applied on the aggregation result from DSL. (2) For customer, comparing with JDBC format, the original response from Elasticsearch is not easy to understand.
PR includes the following changes
4.1. https://github.com/penghuo/sql/blob/jdbc-format/docs/user/interfaces/protocol.rst#elasticsearch-dsl
4.2. https://github.com/penghuo/sql/blob/jdbc-format/docs/user/admin/settings.rst#opendistro-sql-query-response-format
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.