Reset mutex callbacks to the default version when finished #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a PKCS11 API caller provided own mutex handling callbacks, we need to ensure they aren't used after C_Finalize is called and SoftHSM instance is recycled. Inability to do so may lead to a situation where callbacks might be provided by a different dynamically loaded object which is removed after C_Finalize() call. Thus, callback pointers become invalid and calling them leads to crashes. Fixes: opendnssec#408 Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
|
I ran a few heavy tests -- installing FreeIPA -- and it succeeded with this patch. FreeIPA makes use of SoftHSMv2 for DNSSEC and also Fedora makes SoftHSMv2 tokens available via p11-kit, thus loading in all NSS tools by default. All is working now. I'd appreciate any reaction from the upstream developers and get this patch merged. Thanks in advance! |
|
Hi Alexander,
Thanks for the patch. It looks good to me, but I would prefer it if
@bellgrim does the merge, and currently has limited availability. We'll
try to merge it upstream as soon as possible.
Cheers,
Roland
Alexander Bokovoy wrote:
… I ran a few heavy tests -- installing FreeIPA -- and it succeeded with
this patch. FreeIPA makes use of SoftHSMv2 for DNSSEC and also Fedora
makes SoftHSMv2 tokens available via p11-kit, thus loading in all NSS
tools by default. All is working now.
I'd appreciate any reaction from the upstream developers and get this
patch merged. Thanks in advance!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#409 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABpE73xJ6r_9XUAsRPN9rW5G8dJf-XDNks5uMGVxgaJpZM4VoH9A>.
--
-- Roland M. van Rijswijk-Deij
-- SURFnet bv
-- w: https://www.surf.nl/en/about-surf/subsidiaries/surfnet
-- e: roland.vanrijswijk@surfnet.nl
|
|
Thank you for the patch! Will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PKCS11 API caller provided own mutex handling callbacks,
we need to ensure they aren't used after C_Finalize is called
and SoftHSM instance is recycled.
Inability to do so may lead to a situation where callbacks might
be provided by a different dynamically loaded object which is removed
after C_Finalize() call. Thus, callback pointers become invalid and
calling them leads to crashes.
Fixes: #408
Signed-off-by: Alexander Bokovoy abokovoy@redhat.com