Mark as not initialized in destructor #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, we'll review it and merge it if it passes all build tests. |
|
These failures in the CI seem to be unrelated with the change I proposed (I'm seeing failures when running the tests using the current develop branch). Is there anything I can do? |
Set isInitialised field as false in SoftHSM::~SoftHSM() to avoid access to NULL pointers when running callbacks registered by atexit(). Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
ansasaki
force-pushed
the
mark_deinitialized
branch
from
7d5529f
to
f536e8b
Compare
|
Yes, certainly, thanks for reminding us, @halderen is actually collecting input for a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #418
I was investigating a crash similar to #417 which happened if a wrong PIN was provided when using the openssl + engine_pkcs11 + SoftHSM combination. The root of the problem is that the destructor for SoftHSM can be executed before the
atexit()handlers installed by other libraries holding references to SoftHSM.In one particular case, the engine_pkcs11 would call
SoftHSM::C_CloseSession()when exiting, which would end in a crash inHandleManager::getSession()because thehandleManagerhad been destroyed earlier.The bug was reported as part of OpenSC/libp11#273