From 7641de83e339d9bc7367c76bdcf36a43af3bf888 Mon Sep 17 00:00:00 2001 From: Niladri Halder Date: Mon, 24 Jul 2023 11:40:42 +0000 Subject: [PATCH 1/3] feat(mod): update openebs/lib-csi to v0.8.0 Signed-off-by: Niladri Halder --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index 078593f..1b0879d 100644 --- a/go.mod +++ b/go.mod @@ -7,7 +7,7 @@ require ( github.com/kubernetes-csi/csi-lib-utils v0.9.1 github.com/onsi/ginkgo v1.16.4 github.com/onsi/gomega v1.27.4 - github.com/openebs/lib-csi v0.7.0 + github.com/openebs/lib-csi v0.8.0 github.com/pkg/errors v0.9.1 github.com/prometheus/client_golang v1.15.1 github.com/spf13/cobra v1.6.0 diff --git a/go.sum b/go.sum index c40529e..3f2393a 100644 --- a/go.sum +++ b/go.sum @@ -308,8 +308,8 @@ github.com/onsi/gomega v1.27.1/go.mod h1:aHX5xOykVYzWOV4WqQy0sy8BQptgukenXpCXfad github.com/onsi/gomega v1.27.3/go.mod h1:5vG284IBtfDAmDyrK+eGyZmUgUlmi+Wngqo557cZ6Gw= github.com/onsi/gomega v1.27.4 h1:Z2AnStgsdSayCMDiCU42qIz+HLqEPcgiOCXjAU/w+8E= github.com/onsi/gomega v1.27.4/go.mod h1:riYq/GJKh8hhoM01HN6Vmuy93AarCXCBGpvFDK3q3fQ= -github.com/openebs/lib-csi v0.7.0 h1:n9QjgL1h5HpA73y3kaPKMO/7qletC27VXYdn0RBLWBs= -github.com/openebs/lib-csi v0.7.0/go.mod h1:e1WhYqEqiQq8d5GziJ9arNZ39MPocRCg3olNHGwW2e0= +github.com/openebs/lib-csi v0.8.0 h1:lxhv/SRjS7DBz7vTLkaDPd/FJnUftofxSFTU4fdZzW0= +github.com/openebs/lib-csi v0.8.0/go.mod h1:4yc0Q1thH+oU80z73zGELfrOw2yeLdLNIRmcrxBxsBc= github.com/pborman/uuid v0.0.0-20170612153648-e790cca94e6c/go.mod h1:VyrYX9gd7irzKovcSS6BIIEwPRkP2Wm2m9ufcdFSJ34= github.com/peterbourgon/diskv v2.0.1+incompatible/go.mod h1:uqqh8zWWbv1HBMNONnaR/tNboyR3/BZd58JJSHlUSCU= github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= From 86f25a6a935d0e3106adaea96a70ab378e3b2d19 Mon Sep 17 00:00:00 2001 From: Niladri Halder Date: Mon, 24 Jul 2023 11:42:53 +0000 Subject: [PATCH 2/3] feat(ci): update ci - use medyagh/setup-minikube instead of manusa/actions-setup-minikube - update the version of docker/login-action to v2 - use kubernetes v1.27.3 when running BDD tests Signed-off-by: Niladri Halder --- .github/workflows/build.yml | 21 ++++++++++++--------- .github/workflows/pull_request.yml | 13 ++++++++----- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8a73fcb..793201c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -60,7 +60,7 @@ jobs: strategy: fail-fast: true matrix: - kubernetes: [v1.25.10] + kubernetes: [v1.27.3] steps: - name: Checkout uses: actions/checkout@v2 @@ -72,11 +72,14 @@ jobs: cache: false - name: Setup Minikube-Kubernetes - uses: manusa/actions-setup-minikube@v2.7.2 + uses: medyagh/setup-minikube@latest with: - minikube version: v1.26.1 - kubernetes version: ${{ matrix.kubernetes }} - github token: ${{ secrets.GITHUB_TOKEN }} + cache: false + minikube-version: 1.31.1 + driver: none + kubernetes-version: ${{ matrix.kubernetes }} + cni: calico + start-args: '--install-addons=false' - name: Build images locally run: make device-driver-image || exit 1; @@ -100,7 +103,7 @@ jobs: [ -z "${{ secrets.IMAGE_ORG }}" ] && IMAGE_ORG=openebs || IMAGE_ORG=${{ secrets.IMAGE_ORG}} echo "IMAGE_ORG=${IMAGE_ORG}" >> $GITHUB_ENV - name: Login to Docker Hub - uses: docker/login-action@v1 + uses: docker/login-action@v2 with: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }} @@ -174,20 +177,20 @@ jobs: version: v0.5.1 - name: Login to Docker Hub - uses: docker/login-action@v1 + uses: docker/login-action@v2 with: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }} - name: Login to Quay - uses: docker/login-action@v1 + uses: docker/login-action@v2 with: registry: quay.io username: ${{ secrets.QUAY_USERNAME }} password: ${{ secrets.QUAY_TOKEN }} - name: Login to GHCR - uses: docker/login-action@v1 + uses: docker/login-action@v2 with: registry: ghcr.io username: ${{ github.actor }} diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 104f981..b83ce39 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -66,7 +66,7 @@ jobs: strategy: fail-fast: true matrix: - kubernetes: [v1.25.10] + kubernetes: [v1.27.3] steps: - name: Checkout uses: actions/checkout@v2 @@ -78,11 +78,14 @@ jobs: cache: false - name: Setup Minikube-Kubernetes - uses: manusa/actions-setup-minikube@v2.7.2 + uses: medyagh/setup-minikube@latest with: - minikube version: v1.26.1 - kubernetes version: ${{ matrix.kubernetes }} - github token: ${{ secrets.GITHUB_TOKEN }} + cache: false + minikube-version: 1.31.1 + driver: none + kubernetes-version: ${{ matrix.kubernetes }} + cni: calico + start-args: '--install-addons=false' - name: Build images locally run: make device-driver-image || exit 1; From 5107264afd01f7dccf9a0596b29412a186c144f6 Mon Sep 17 00:00:00 2001 From: Niladri Halder Date: Mon, 24 Jul 2023 11:46:40 +0000 Subject: [PATCH 3/3] feat(deploy): update yamls - update sig-storage/csi-node-driver-registrar image to v2.8.0 - update sig-storage/csi-provisioner to v3.5.0 - use 'spec.serviceAccountName' instead of 'spec.ServiceAccount' Signed-off-by: Niladri Halder --- deploy/device-operator.yaml | 8 ++++---- deploy/yamls/device-driver.yaml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/deploy/device-operator.yaml b/deploy/device-operator.yaml index 3db6a23..e4dbc50 100644 --- a/deploy/device-operator.yaml +++ b/deploy/device-operator.yaml @@ -376,10 +376,10 @@ spec: - openebs-device-controller topologyKey: "kubernetes.io/hostname" priorityClassName: system-cluster-critical - serviceAccount: openebs-device-controller-sa + serviceAccountName: openebs-device-controller-sa containers: - name: csi-provisioner - image: registry.k8s.io/sig-storage/csi-provisioner:v3.0.0 + image: registry.k8s.io/sig-storage/csi-provisioner:v3.5.0 imagePullPolicy: IfNotPresent args: - "--csi-address=$(ADDRESS)" @@ -500,11 +500,11 @@ spec: openebs.io/version: ci spec: priorityClassName: system-node-critical - serviceAccount: openebs-device-node-sa + serviceAccountName: openebs-device-node-sa hostNetwork: true containers: - name: csi-node-driver-registrar - image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.3.0 + image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0 imagePullPolicy: IfNotPresent args: - "--v=5" diff --git a/deploy/yamls/device-driver.yaml b/deploy/yamls/device-driver.yaml index 2c09e2c..0ea7a8f 100644 --- a/deploy/yamls/device-driver.yaml +++ b/deploy/yamls/device-driver.yaml @@ -135,10 +135,10 @@ spec: - openebs-device-controller topologyKey: "kubernetes.io/hostname" priorityClassName: system-cluster-critical - serviceAccount: openebs-device-controller-sa + serviceAccountName: openebs-device-controller-sa containers: - name: csi-provisioner - image: registry.k8s.io/sig-storage/csi-provisioner:v3.0.0 + image: registry.k8s.io/sig-storage/csi-provisioner:v3.5.0 imagePullPolicy: IfNotPresent args: - "--csi-address=$(ADDRESS)" @@ -259,11 +259,11 @@ spec: openebs.io/version: ci spec: priorityClassName: system-node-critical - serviceAccount: openebs-device-node-sa + serviceAccountName: openebs-device-node-sa hostNetwork: true containers: - name: csi-node-driver-registrar - image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.3.0 + image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0 imagePullPolicy: IfNotPresent args: - "--v=5"