New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable arguments to the functions #59

Merged
merged 1 commit into from Oct 13, 2018

Conversation

Projects
None yet
4 participants
@farhaanbukhsh
Contributor

farhaanbukhsh commented Oct 13, 2018

Signed-off-by: Farhaan Bukhsh farhaan.bukhsh@gmail.com

Add customizable arguments to the functions
Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
@Akash4927

Thanks for the PR @farhaanbukhsh
looks good to me.

@sonasingh46

lgtm

@codecov-io

This comment has been minimized.

codecov-io commented Oct 13, 2018

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   42.46%   42.46%           
=======================================
  Files           5        5           
  Lines         146      146           
=======================================
  Hits           62       62           
  Misses         83       83           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e3b12...d60b278. Read the comment docs.

@Akash4927 Akash4927 merged commit a175ba4 into openebs:master Oct 13, 2018

3 checks passed

codecov/patch Coverage not affected when comparing b2e3b12...d60b278
Details
codecov/project 42.46% remains the same compared to b2e3b12
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment