Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US3959 feat(ephemeral_disk) : exchanging quorum while doing handshake #164

Merged
merged 3 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@pawanpraka1
Copy link

commented Dec 7, 2018

Signed-off-by: Pawan pawanprakash101@gmail.com

US3959 feat(ephemeral_disk) : exchanging quorum while doing handshake
Signed-off-by: Pawan <pawanprakash101@gmail.com>

@pawanpraka1 pawanpraka1 requested a review from vishnuitta Dec 7, 2018

fixing a test case
Signed-off-by: Pawan <pawanprakash101@gmail.com>
@@ -457,6 +459,24 @@ uzfs_zinfo_store_last_committed_degraded_io_no(zvol_info_t *zinfo,
DEGRADED_IO_SEQNUM, io_seq);
}

uint8_t
uzfs_get_quorum(zvol_state_t *zv)

This comment has been minimized.

Copy link
@vishnuitta

vishnuitta Dec 10, 2018

Member

lets make this as uzfs_zinfo_get_quorum and uzfs_zinfo_set_quorum and take 'zinfo' as argument rather than zvol_state_t, so that, in these APIs, we can take zinfo->main_zv and return the quorum value of main_zv.

making the function more generic
Signed-off-by: Pawan <pawanprakash101@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

commented Dec 10, 2018

Codecov Report

Merging #164 into zfs-0.7-release will decrease coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           zfs-0.7-release     #164      +/-   ##
===================================================
- Coverage            52.71%   52.37%   -0.35%     
===================================================
  Files                  240      240              
  Lines                78018    78026       +8     
===================================================
- Hits                 41129    40863     -266     
- Misses               36889    37163     +274

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56523aa...b28beb5. Read the comment docs.

@vishnuitta
Copy link
Member

left a comment

changes are good

@vishnuitta vishnuitta merged commit 19a6836 into openebs:zfs-0.7-release Dec 10, 2018

6 checks passed

Better Code Hub ✅ Better Code Hub approves this code
Details
ci/circleci: build_tag_0 Your tests passed on CircleCI!
Details
ci/circleci: build_tag_1 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 52.71%)
Details
codecov/project Absolute coverage decreased by -0.34% but relative coverage increased by +47.28% compared to 56523aa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

vishnuitta added a commit to vishnuitta/zfs that referenced this pull request Dec 18, 2018

US3959 feat(ephemeral_disk) : exchanging quorum while doing handshake (
…openebs#164)

Signed-off-by: Pawan <pawanprakash101@gmail.com>
(cherry picked from commit 19a6836)

pawanpraka1 added a commit that referenced this pull request Dec 18, 2018

US3959 feat(ephemeral_disk) : exchanging quorum while doing handshake (
…#164)

Signed-off-by: Pawan <pawanprakash101@gmail.com>
(cherry picked from commit 19a6836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.